Skip to content

update to_ref test to use Eigen::all instead of Eigen::placeholders::all#3187

Merged
WardBrian merged 2 commits into
developfrom
fix/eigen-placeholder-all-to-ref-test
Jun 3, 2025
Merged

update to_ref test to use Eigen::all instead of Eigen::placeholders::all#3187
WardBrian merged 2 commits into
developfrom
fix/eigen-placeholder-all-to-ref-test

Conversation

@SteveBronder

Copy link
Copy Markdown
Collaborator

Summary

Develop uses -Werror and eigen deprecated Eigen::placeholders:all for Eigen::all. So this just changes those.

Checklist

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian WardBrian merged commit f6e16b2 into develop Jun 3, 2025
33 of 34 checks passed
@WardBrian WardBrian deleted the fix/eigen-placeholder-all-to-ref-test branch June 3, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants